Skip to content

added missing .js suffix on import #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelgj merged 1 commit into from
May 13, 2024
Merged

added missing .js suffix on import #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/plugins/firebase/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import { genkitPlugin, Plugin } from '@genkit-ai/core';
import { FirestoreStateStore } from '@genkit-ai/flow';
import { FirestoreTraceStore } from './firestoreTraceStore';
import { FirestoreTraceStore } from './firestoreTraceStore.js';
export { defineFirestoreRetriever } from './firestoreRetriever.js';

interface FirestorePluginParams {
Expand Down
21 changes: 0 additions & 21 deletions js/testapps/rag/genkit-tools.conf.js
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions js/testapps/tools-config-test1/genkit-tools.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
// TODO(sam-gc): Update this once we have actual libraries/plugins...

module.exports = {
builder: {
cmd: "echo 'Custom message....' && npm run build",
Copy link
Collaborator

@tonybaroneee tonybaroneee May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh?
Copy link
Collaborator Author

@pavelgj pavelgj May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a demo sample.... custom builder command...
},
cliPlugins: [
{
name: 'My tool',
Expand Down