Skip to content

Conversation

@pavelgj
Copy link
Collaborator

@pavelgj pavelgj commented Dec 11, 2024

No description provided.

@pavelgj pavelgj requested a review from chrisraygill December 11, 2024 18:54
@peterfriese peterfriese self-requested a review December 11, 2024 22:43
Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pavelgj - is the gray background for the logo intentional? I think the previous version (with light and dark mode assets) looked perfectly fine both in light and dark mode. Plus, it also uses the official logo from the Firebase brand toolkit (https://firebase.google.com/brand-guidelines)

@pavelgj
Copy link
Collaborator Author

pavelgj commented Dec 12, 2024

Hi @pavelgj - is the gray background for the logo intentional? I think the previous version (with light and dark mode assets) looked perfectly fine both in light and dark mode. Plus, it also uses the official logo from the Firebase brand toolkit (https://firebase.google.com/brand-guidelines)

yeah, this readme needs to be renderable in places other than GH (ex. we're working on API reference, and it uses that readme as the landing page). Current logo is using github specific markdown render features to swap out images depending on the GH theme which doesn't work in other places.

@peterfriese
Copy link
Contributor

Hi @pavelgj - is the gray background for the logo intentional? I think the previous version (with light and dark mode assets) looked perfectly fine both in light and dark mode. Plus, it also uses the official logo from the Firebase brand toolkit (https://firebase.google.com/brand-guidelines)

yeah, this readme needs to be renderable in places other than GH (ex. we're working on API reference, and it uses that readme as the landing page). Current logo is using github specific markdown render features to swap out images depending on the GH theme which doesn't work in other places.

Understood. The brand guidelines explicitly say "do not alter the logo", and using a different background color falls in this category.

Can we either

  1. Use a different file as the landing page for the ref docs
  2. Cherry pick the GitHub CSS and use the relevant parts in the ref docs?
@pavelgj pavelgj closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants