feat(go): add image support to vertexai plugin #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
reviewed
Dec 2, 2024
Collaborator
apascal07
left a comment
apascal07
left a comment
There was a problem hiding this comment.
Can you add tests and/or a sample that uses this? I see there are many more parameters in JS like watermark, aspect ratio, etc. How come these were omitted?
go/plugins/vertexai/vertexai.go
Outdated
| input *ai.ModelRequest, | ||
| cb func(context.Context, *ai.ModelResponseChunk) error, | ||
| ) (*ai.ModelResponse, error) { | ||
| if strings.HasPrefix(name, "imagen") { |
Collaborator
There was a problem hiding this comment.
This code block is auto-generated/copied from googleai.go so it's going to get overwritten. Can you figure out a way around it?
Contributor
Author
There was a problem hiding this comment.
I just put outside of the code copied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to vertexai plugin
Checklist (if applicable):