Lifting definePrompt to genkit core #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
reviewed
May 2, 2024
pavelgj
reviewed
May 2, 2024
Collaborator
pavelgj
left a comment
pavelgj
left a comment
There was a problem hiding this comment.
Overall -- I like this a lot!
pavelgj
approved these changes
May 2, 2024
MichaelDoyle
reviewed
May 3, 2024
- Moving definePrompt into ai package - Reimagining dotprompt to follow the new contract - Adding renderPrompt veneer to facilitate using prompts in code - Updating tests and samples to use defineDotprompt. - Adding new docs for prompts and updating dotprompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lifts prompts into a core Genkit action and facilitates paths to supporting alternative prompting approaches and/or templating systems. It also tweaks Dotprompt somewhat to interact with the new structure.