Fix pnpm-lock.yaml and build dotprompt plugin first #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaesterChestnut
approved these changes
May 10, 2024
maxl0rd
approved these changes
May 10, 2024
cabljac
pushed a commit
to invertase/genkit
that referenced
this pull request
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
pnpm-lock.yamlto what is auto-generated (correcting some manual edits from the dotprompt PR before).Also,
plugins/evaluatordepends onplugins/dotprompt, so this ensures that dotprompt is built first (since we parallelize plugin builds and cannot guarantee build order there).