Set span type to prompt when rendering a dotprompt #1028
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable the Dev UI to properly deal with prompts in a more generic way when rendering badges, loading traces into the runner, etc, versus having to check for each different type of prompt [prompt, DOTprompt, FOOprompt] etc.
Member
Author
|
cc @tonybaroneee this will be relevant for the firebase console as well. |
tonybaroneee
approved these changes
Oct 8, 2024
Contributor
|
I think this is on the right track, but I have a counter proposal since this is colliding with the feature tracing change. |
tonybaroneee
requested changes
Oct 8, 2024
Collaborator
tonybaroneee
left a comment
tonybaroneee
left a comment
There was a problem hiding this comment.
(See Max's comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable the Dev UI to properly deal with prompts in a more generic way when rendering badges, loading traces into the runner, etc, versus having to check for each different type of prompt ['prompt', 'DOTprompt', 'FOOprompt'] etc.
Checklist (if applicable):