Skip to content

fix(js): fix streaming json mode in gemini plugins #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cabljac merged 1 commit into from
Oct 3, 2024
Merged

fix(js): fix streaming json mode in gemini plugins #1003

cabljac merged 1 commit into from
Oct 3, 2024

Conversation

@cabljac
Copy link
Contributor

@cabljac cabljac commented Oct 3, 2024 •
edited
Loading

This PR fixes a regression introduced with strict JSON mode on Gemini plugins (Google AI and Vertex AI plugins)

Should fix #958 in main

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Docs updated
@cabljac cabljac merged commit aeb91b0 into main Oct 3, 2024
@cabljac cabljac deleted the @invertase/fix-streaming-json branch October 3, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@cabljac @pavelgj