Fix OAuth2.0 based authentication examples problems using cookie #826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some examples using OAuth 2.0 based authentication with cookie doesn't work correctly in modern browser like Google Chrome and Firefox.
In these examples,
statevalue are not set correctly in cookie because the requests for Cloud Functions are sent in cross domain and are not Top Level Navigation.If
SameSiteattribute are not set, browsers treats it asLaxvalue by default.So I thinkSameSiteattribute should be set toNone.Edit
The solution in #849 seems to be better, so the example in spotify-auth followed this.
State cookie is sent through the same domain and use
__sessionkey instead ofstate.The examples of Instagram and Linkedin are fixed by #849, so I reverted modification for these examples.