Fix Firestore index deployment crash when indexes are undefined #9679
Conversation
Prevent a crash in `deployIndexes` by checking if `context.firestore.indexes` is defined before iterating over it. This addresses an issue where `firestoreIndexes` flag is true, but `context.firestore.indexes` is undefined, causing a `TypeError`. Added a unit test to verify the fix and ensure no regression. fixes #8114
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change fixes a bug where
firebase deploy --only firestore:indexeswould crash withTypeError: Cannot read properties of undefined (reading 'map')ifcontext.firestore.indexeswas undefined. This could happen if the preparation phase determined there were no indexes to deploy or failed to populate the context, but the deployment phase still attempted to access it.I added a check
if (!indexesContext)insrc/deploy/firestore/deploy.tsto return early if the indexes are missing. I also added a unit test insrc/deploy/firestore/deploy.spec.tsto verify that the deployment process now handles this case gracefully without crashing.PR created automatically by Jules for task 12633729693633993961 started by @joehan