Fix multi tab persistence issue

[milaGGL]

Bug: when multi-tab persistence is enabled, the queries in the secondary tabs tend to raise empty snapshot or return flaky results.

[changeset-bot]

🦋 Changeset detected

Latest commit: f32efea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Changeset File Check ✅

• No modified packages are missing from the changeset file.
• No changeset formatting errors detected.

[google-oss-bot]

Size Report ¹

Affected Products

• @firebase/firestore

  Type	Base (9cbb184)	Merge (e5ffdfc)	Diff
  esm5	363 kB	363 kB	-2 B (-0.0%)
  main	582 kB	582 kB	-11 B (-0.0%)

• firebase

  Type	Base (9cbb184)	Merge (e5ffdfc)	Diff
  firebase-compat.js	786 kB	786 kB	+1 B (+0.0%)
  firebase-firestore-compat.js	341 kB	341 kB	+1 B (+0.0%)

Test Logs

• Base (9cbb184): https://github.com/firebase/firebase-js-sdk/actions/runs/9081305457
• Merge (e5ffdfc): https://github.com/firebase/firebase-js-sdk/actions/runs/9082189764

1. https://storage.googleapis.com/firebase-sdk-metric-reports/sy4Xtpah12.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (9cbb184) and merge commit (a5860cb).

Test Logs

• Base (9cbb184): https://github.com/firebase/firebase-js-sdk/actions/runs/9081305457
• Merge (a5860cb): https://github.com/firebase/firebase-js-sdk/actions/runs/9082179719

1. https://storage.googleapis.com/firebase-sdk-metric-reports/tDtIMy4q1D.html

[atsjo]

When using includeMetadataChanges: true, this "fix" has broken the metadata.fromCache value beeing set to false for queries in the secondary tabs... In these cases we SHOULD have empty snapshots where only the meta-data change. I'll report a new issue for this, I have verified that firebase 10.12.0 (the version before this commit) works, so pretty sure this is the reason...