Vector Type - #8215
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 76f2972 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1This report is too large (631,171 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
…hange unrelated to this PR.
wu-hui
approved these changes
May 6, 2024
MarkDuckworth
marked this pull request as ready for review
July 29, 2024 22:51
Contributor
Changeset File Check ✅
|
hsubox76
approved these changes
Aug 6, 2024
egilmorez
approved these changes
Aug 9, 2024
egilmorez
left a comment
egilmorez
left a comment
Contributor
There was a problem hiding this comment.
LG with tiny nits, thanks!
In a review this size, it would be great to have a way to know which files are not public-facing, like an exclusion list. I'll ask Christina about that.
…uckworth/vector-type
…ase-js-sdk into markduckworth/vector-type
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for reading and writing Firestore vectors.