Don't delete on update failure by zwu52 · Pull Request #8141 · firebase/firebase-js-sdk

zwu52 · 2024-04-08T16:48:33Z

Revised token update logic to keep existing tokens during update failures, preventing unnecessary deletions for transient issues.

context: b/329447928

changeset-bot · 2024-04-08T16:48:37Z

🦋 Changeset detected

Latest commit: f04260f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/messaging	Patch
firebase	Patch
@firebase/messaging-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2024-04-08T17:04:46Z

Size Report ¹

Affected Products

@firebase/messaging
Type Base (b64b947) Merge (f87cc5d) Diff
browser 21.4 kB 21.3 kB -37 B (-0.2%)
esm5 26.8 kB 26.8 kB -58 B (-0.2%)
main 27.5 kB 27.4 kB -58 B (-0.2%)
module 21.4 kB 21.3 kB -37 B (-0.2%)
@firebase/messaging-sw
Type Base (b64b947) Merge (f87cc5d) Diff
main 30.5 kB 30.4 kB -58 B (-0.2%)
module 23.6 kB 23.6 kB -37 B (-0.2%)
bundle
Type Base (b64b947) Merge (f87cc5d) Diff
messaging (send + receive) 47.2 kB 46.8 kB -395 B (-0.8%)

`firebase`

Type	Base (`b64b947`)	Merge (f87cc5d)	Diff
firebase-compat.js	786 kB	786 kB	-24 B (-0.0%)
firebase-messaging-compat.js	38.4 kB	38.4 kB	-24 B (-0.1%)
firebase-messaging-sw.js	30.2 kB	30.2 kB	-29 B (-0.1%)
firebase-messaging.js	28.8 kB	28.7 kB	-29 B (-0.1%)

Test Logs

Base (b64b947): https://github.com/firebase/firebase-js-sdk/actions/runs/8544541010
Merge (f87cc5d): https://github.com/firebase/firebase-js-sdk/actions/runs/8604065764

https://storage.googleapis.com/firebase-sdk-metric-reports/6BjGNxFB7B.html

google-oss-bot · 2024-04-08T17:16:12Z

Size Analysis Report ¹

Affected Products

`@firebase/messaging`

deleteToken
Size
Type Base (b64b947) Merge (f87cc5d) Diff
size 12.8 kB 12.7 kB -11 B (-0.1%)
size-with-ext-deps 39.3 kB 39.3 kB -12 B (-0.0%)

`getMessaging`

Size

Type	Base (`b64b947`)	Merge (f87cc5d)	Diff
size	13.2 kB	12.8 kB	-389 B (-2.9%)
size-with-ext-deps	46.9 kB	46.5 kB	-395 B (-0.8%)

Dependency

Type Base (b64b947) Merge (f87cc5d) Diff

functions

39 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbRemove
dbSet
deleteTokenInternal
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMessagingInWindow
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

37 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMessagingInWindow
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

- dbRemove
- deleteTokenInternal

`getToken`

Size

Type	Base (`b64b947`)	Merge (f87cc5d)	Diff
size	12.6 kB	12.2 kB	-391 B (-3.1%)
size-with-ext-deps	39.2 kB	38.8 kB	-395 B (-1.0%)

Dependency

Type Base (b64b947) Merge (f87cc5d) Diff

functions

38 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbRemove
dbSet
deleteTokenInternal
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

36 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

- dbRemove
- deleteTokenInternal

`isSupported`

Size

Type	Base (`b64b947`)	Merge (f87cc5d)	Diff
size	13.0 kB	12.6 kB	-390 B (-3.0%)
size-with-ext-deps	39.5 kB	39.1 kB	-395 B (-1.0%)

Dependency

Type Base (b64b947) Merge (f87cc5d) Diff

functions

38 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbRemove
dbSet
deleteTokenInternal
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

36 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
isWindowSupported
logToScion
messageEventListener
migrateOldDatabase
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

- dbRemove
- deleteTokenInternal

`onMessage`

Size

Type	Base (`b64b947`)	Merge (f87cc5d)	Diff
size	12.8 kB	12.4 kB	-391 B (-3.1%)
size-with-ext-deps	39.3 kB	38.9 kB	-395 B (-1.0%)

Dependency

Type Base (b64b947) Merge (f87cc5d) Diff

functions

39 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbRemove
dbSet
deleteTokenInternal
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
onMessage
onMessage$1
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

37 dependencies

_mergeStrings
arrayToBase64
base64ToArray
checkTokenDetails
dbGet
dbSet
externalizePayload
extractAppConfig
getBody
getDbPromise
getEndpoint
getEventType
getHeaders
getKey
getMissingValueError
getNewToken
getPushSubscription
getToken$1
getTokenInternal
isConsoleMessage
isTokenValid
logToScion
messageEventListener
migrateOldDatabase
onMessage
onMessage$1
propagateDataPayload
propagateFcmOptions
propagateNotificationPayload
registerDefaultSw
registerMessagingInWindow
requestDeleteToken
requestGetToken
requestUpdateToken
updateSwReg
updateToken
updateVapidKey

- dbRemove
- deleteTokenInternal

Test Logs

Base (b64b947): https://github.com/firebase/firebase-js-sdk/actions/runs/8544541010
Merge (f87cc5d): https://github.com/firebase/firebase-js-sdk/actions/runs/8604065764

https://storage.googleapis.com/firebase-sdk-metric-reports/4fJRQ5PhEh.html

Don't delete on update failure

7f7adb1

zwu52 requested a review from a team as a code owner April 8, 2024 16:48

update

0a40485

zwu52 requested review from a team as code owners April 8, 2024 17:11

Update cyan-rats-itch.md

f04260f

hsubox76 approved these changes Apr 8, 2024

View reviewed changes

zwu52 merged commit f1a57d0 into master Apr 8, 2024

zwu52 deleted the dont_delete_on_refresh_failure branch April 8, 2024 22:35

google-oss-bot mentioned this pull request Apr 9, 2024

Version Packages #8143

Merged

firebase locked and limited conversation to collaborators May 9, 2024

zwu52 restored the dont_delete_on_refresh_failure branch July 24, 2024 20:03

paulb777 deleted the dont_delete_on_refresh_failure branch February 20, 2026 01:56

Navigation Menu

Uh oh!

Don't delete on update failure - #8141

Don't delete on update failure#8141
zwu52 merged 3 commits into
masterfrom
dont_delete_on_refresh_failure

zwu52 commented Apr 8, 2024 •

edited

Loading

changeset-bot Bot commented Apr 8, 2024 •

edited

Loading

google-oss-bot commented Apr 8, 2024 •

edited

Loading

`@firebase/messaging`

`@firebase/messaging-sw`

`bundle`

`firebase`

google-oss-bot commented Apr 8, 2024 •

edited

Loading

`@firebase/messaging`

`deleteToken`

`getMessaging`

`getToken`

`isSupported`

`onMessage`

Labels

3 participants

Uh oh!

Conversation

zwu52 commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

changeset-bot Bot commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

google-oss-bot commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/messaging

@firebase/messaging-sw

bundle

firebase

Test Logs

google-oss-bot commented Apr 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/messaging

deleteToken

getMessaging

getToken

isSupported

onMessage

Test Logs

Labels

3 participants

zwu52 commented Apr 8, 2024 •

edited

Loading

changeset-bot Bot commented Apr 8, 2024 •

edited

Loading

google-oss-bot commented Apr 8, 2024 •

edited

Loading

Size Report ¹

`@firebase/messaging`

`@firebase/messaging-sw`

`bundle`

`firebase`

google-oss-bot commented Apr 8, 2024 •

edited

Loading

Size Analysis Report ¹

`@firebase/messaging`

`deleteToken`

`getMessaging`

`getToken`

`isSupported`

`onMessage`