Fix ToTP typings issue - #7179
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c5513a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hsubox76
marked this pull request as ready for review
March 31, 2023 16:33
hsubox76
requested review from
dwyfrequency,
egilmorez,
lisajian,
markarndt,
prameshj,
renkelvin and
sam-gc
as code owners
March 31, 2023 16:33
renkelvin
approved these changes
Mar 31, 2023
Collaborator
Size Report 1Affected ProductsNo changes between base commit (8c9f8c8) and merge commit (166e89c).Test Logs |
henriquesschmitt
approved these changes
Mar 31, 2023
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (8c9f8c8) and merge commit (166e89c).Test Logs |
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The const enum is internal and not exported with public types, causing an error since it's referenced.
I believe other publicly exported auth classes avoid this by following the pattern here: https://github.com/firebase/firebase-js-sdk/blob/1d5646ed68ccc59dde27983bfe2575db5ecb528d/packages/auth/src/platform_browser/providers/phone.ts#L55
So I've done the same for
TotpMultiFactorGenerator.Fixes #7174