Catch getDefaults() errors and do not throw - #6686
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0aaf837 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
hsubox76
marked this pull request as ready for review
October 12, 2022 17:52
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to various frameworks and environments, we have been encountering a lot of special cases not accounted for in
getDefaults()(such asprocessexisting butprocess.envnot existing in Nuxt 3, ordocumentexisting butdocument.cookiethrowing in Angular Universal).Adding an overall try/catch block to
getDefaults()so that if it runs into any errors we haven't thought of, it won't block execution of the rest of Firebase. It will log a console.info so we can find out about these cases and account for them.Also added a separate catch specifically for the Angular Universal case. Yes, this would be caught by the overall try/catch already, but I'd like to put in the specific cases as we find them so we know the specifics of the various environments we're dealing with, as this knowledge will help us with SSR support going forward.
Fixes #6677