Skip to content

Updated type of action parameter for DataSnapshot#forEach - #6374

Merged
maneesht merged 3 commits into
firebase:masterfrom
bookcreator:fix_6368
Jul 20, 2022
Merged

Updated type of action parameter for DataSnapshot#forEach#6374
maneesht merged 3 commits into
firebase:masterfrom
bookcreator:fix_6368

Conversation

@rhodgkins

@rhodgkins rhodgkins commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Fixes #6368
@changeset-bot

changeset-bot Bot commented Jun 22, 2022 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c353757

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/database Patch
@firebase/database-compat Patch
@firebase/database-types Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR
@rhodgkins
rhodgkins marked this pull request as ready for review June 22, 2022 14:26
maneesht
maneesht reviewed Jun 22, 2022
View reviewed changes
Comment thread .changeset/silent-carrots-bathe.md Outdated
@rhodgkins
rhodgkins requested a review from maneesht June 23, 2022 08:02
@rhodgkins

rhodgkins commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

Thanks @maneesht - the failing API report check, do I need to do anything?
@maneesht

maneesht commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

@rhodgkins - not sure if it will help, but your forked repo is behind, can you update it?
@rhodgkins

rhodgkins commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

@maneesht rebased but no change. According to the logs its missing a token...?
@maneesht

maneesht commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

Looks like there's an issue related to github actions. We have a fix incoming.
@rhodgkins
rhodgkins requested a review from dwyfrequency as a code owner July 7, 2022 18:07
@rhodgkins

rhodgkins commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

Thanks @jsdt - @maneesht I rebased to include your fix (#6409), but still failing unfortunately...
@rhodgkins

rhodgkins commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

@maneesht what else do I need to do to get this merged...? Rather not have this sit here for months as its such a small change!
@maneesht

maneesht commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

@rhodgkins - can you please run yarn build locally, so that it generates the correct md file, and then commit and push the results?
@rhodgkins

rhodgkins commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

@maneesht done, yep that sorted it 🎉 thanks.
@maneesht
maneesht merged commit 6583808 into firebase:master Jul 20, 2022
@google-oss-bot google-oss-bot mentioned this pull request Aug 4, 2022
Merged
maneesht added a commit that referenced this pull request Aug 16, 2022
@maneesht
Revert "Updated type of action parameter for DataSnapshot#forEach (#6374
1205b3e 
)"

This reverts commit 6583808.
@maneesht maneesht mentioned this pull request Aug 16, 2022
Merged
maneesht added a commit that referenced this pull request Aug 17, 2022
@maneesht
Revert "Updated type of action parameter for DataSnapshot#forEach" (#…
9f1e3c6 
…6536)

* Revert "Updated type of action parameter for DataSnapshot#forEach (#6374)"

This reverts commit 6583808.
@firebase firebase locked and limited conversation to collaborators Aug 20, 2022
@rhodgkins
rhodgkins deleted the fix_6368 branch February 18, 2025 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@rhodgkins @maneesht @jsdt @hsubox76