Fix websocketonly flag - #6126
Merged
Merged
Conversation
maneesht
requested review from
allspain,
hsubox76,
jsdt and
schmidt-sebastian
as code owners
April 6, 2022 20:34
🦋 Changeset detectedLatest commit: f058ac3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Size Report 1Affected ProductsNo changes between base commit (d756f4e) and merge commit (9146618).Test Logs |
maneesht
marked this pull request as draft
April 6, 2022 20:59
Collaborator
Size Analysis Report 1Affected ProductsNo changes between base commit (d756f4e) and merge commit (9146618).Test Logs |
jsdt
reviewed
Apr 6, 2022
| "@firebase/database": patch | ||
| --- | ||
|
|
||
| Fix websocketonly field to be set to true when using websocket db url. |
Contributor
There was a problem hiding this comment.
Could you explain what the websocket url is in parens (ws or wss instead of https)? Then someone can figure out how to use it by reading the release notes.
maneesht
marked this pull request as ready for review
April 6, 2022 22:22
jsdt
approved these changes
Apr 7, 2022
schmidt-sebastian
approved these changes
Apr 8, 2022
| @@ -0,0 +1,34 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2017 Google LLC | |||
jsdt
approved these changes
Apr 8, 2022
hsubox76
approved these changes
Apr 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the webSocketOnly field was incorrectly set to undefined when using a websocket database URL.
When initializing the RepoInfo instance, the
nodeAdminvalue was being passed in as thewebSocketOnlyvalue, leading webSocketOnly to be undefined even when using a websocket url.