Skip to content

Fix query string parsing - #518

Merged
tonymeng merged 3 commits into
masterfrom
tm-fix-qs-parsing
Feb 16, 2018
Merged

Fix query string parsing#518
tonymeng merged 3 commits into
masterfrom
tm-fix-qs-parsing

Conversation

@tonymeng

@tonymeng tonymeng commented Feb 16, 2018

Copy link
Copy Markdown
Contributor

Fixes #517
@tonymeng
tonymeng requested a review from mikelehen as a code owner February 16, 2018 19:04
schmidt-sebastian
schmidt-sebastian approved these changes Feb 16, 2018
View reviewed changes
Comment thread packages/database/src/core/util/libs/parser.ts Outdated
results[decodeURIComponent(kv[0])] = decodeURIComponent(kv[1]);
} else {
warn('Invalid query string segment: ' + segment);
warn('Invalid query string segment: "' + segment + '" in query string: "' + queryString + '"');

@schmidt-sebastian schmidt-sebastian Feb 16, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested:

warn(`Invalid query segment '${segment}' in query '${queryString}'`);
@tonymeng
tonymeng merged commit 2e147ff into master Feb 16, 2018
@tonymeng
tonymeng deleted the tm-fix-qs-parsing branch February 16, 2018 21:53
@spencexyz

spencexyz commented Feb 17, 2018

Copy link
Copy Markdown

Did you guys deploy this on npm?
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-triage

4 participants

@tonymeng @spencexyz @schmidt-sebastian @google-oss-bot