Fix cancelCallback for child_added events - #4832
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 4c804a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
force-pushed
the
mrschmidt/cancel
branch
from
April 24, 2021 02:00
97be041 to
26a893f
Compare
Collaborator
Binary Size ReportAffected SDKs
Test Logs
|
Collaborator
Size Analysis ReportAffected ProductsDiffs between base commit (d47fb41) and head commit (31f6dcab) are too large (479,509 characters) to display. Please check below links to see details from the original test log. Test Logs
|
Feiyang1
approved these changes
Apr 27, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4818
This simplifies the code in ChildEventRegistration. The class is meant to support multiple callbacks, but only one cancel callback. This broke in our refactor. Luckily, the class is never used for more than callback, so I was able to simplify the code and also fix the bug (which was due to the fact that the cancel callback was never registered under 'cancel').