-
Notifications
You must be signed in to change notification settings - Fork 410
feat(appcheck): Add support for minting limited use tokens #3027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the App Check module by enabling the creation of limited use tokens. This feature provides developers with the ability to generate tokens that offer replay protection, making them ideal for securing one-time operations or session-specific interactions within applications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for creating limited-use App Check tokens by adding a limitedUse parameter to the createToken() API. The changes are well-implemented across the API, client, and internal methods, and are accompanied by thorough unit and integration tests. My review includes one suggestion to enhance input validation for the new limitedUse parameter to improve robustness and provide clearer feedback to developers on invalid usage.
| public exchangeToken( | ||
| customToken: string, | ||
| appId: string, | ||
| limitedUse?: boolean | ||
| ): Promise<AppCheckToken> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved robustness and a better developer experience, it would be beneficial to add input validation for the limitedUse parameter. This ensures that if a value is provided, it must be a boolean. This is consistent with how other parameters like appId and customToken are validated within this method, and it provides clearer error messages to developers for invalid inputs.
You can add the following check at the beginning of the function body:
if (typeof limitedUse !== 'undefined' && !validator.isBoolean(limitedUse)) {
throw new FirebaseAppCheckError(
'invalid-argument',
'`limitedUse` must be a boolean value.');
}
This PR adds support for the limitedUse parameter in the
createToken()API of the App Check module. This allows users to generate tokens with replay protection, suitable for one-time use or session-based contexts.RELEASE_NOTE: Added support for creating limited use App Check tokens in the
createToken()API