Remove product prefix from SSRC types #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenh
approved these changes
Mar 15, 2024
Contributor
jenh
left a comment
jenh
left a comment
There was a problem hiding this comment.
Looks good to me; also tested with a local server client--it successfully fetched all configured parameters from Remote Config without error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a Firebase AIP to not include product prefixes in type names.
Discussion
There are already some types with the prefix, but we can avoid adding new types, as discussed with @lahirumaramba.
This change also renames the unused RemoteConfigServerCondition -> NamedServerCondition, in anticipation of #2487.
Testing
Ran npm test and all tests pass.
Functionally tested using a local server.