-
Notifications
You must be signed in to change notification settings - Fork 299
feat(rc): Support Remote Config managed value types (#1164) #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update Remote Config API to support managed value types Added support for Rollouts, Experiments, and Personalization value types in the Remote Config API. - Updated `ParameterValue` to include `RolloutValue`, `PersonalizationValue`, and `ExperimentValue` subclasses. - Added factory methods `ofRollout`, `ofPersonalization`, and `ofExperiment` to `ParameterValue`. - Updated `TemplateResponse` to parse `rolloutValue`, `personalizationValue`, and `experimentValue` fields from the backend response. - Added unit tests for the new value types. --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Summary of ChangesHello @ashish-kothari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Firebase Remote Config API by introducing support for advanced managed value types. This change enables the system to handle more complex configuration scenarios, such as A/B testing, phased rollouts, and personalized content delivery, directly through the Remote Config parameters. The modifications involve extending existing data structures and parsing logic to accommodate these new capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for managed value types (Rollouts, Experiments, and Personalization) in the Remote Config API. The changes are well-structured, adding new subclasses to ParameterValue, corresponding factory methods, and updating TemplateResponse to handle the new types from the backend. The unit tests are also updated to cover these new features. My review includes a critical fix for a potential JSON parsing issue due to a mismatched @Key annotation, suggestions to improve code conciseness using Java Streams, and a naming suggestion to enhance API consistency.
Update Remote Config API to support managed value types
Added support for Rollouts, Experiments, and Personalization value types in the Remote Config API.
ParameterValueto includeRolloutValue,PersonalizationValue, andExperimentValuesubclasses.ofRollout,ofPersonalization, andofExperimenttoParameterValue.TemplateResponseto parserolloutValue,personalizationValue, andexperimentValuefields from the backend response.