Skip to content

Conversation

@ashish-kothari
Copy link

@ashish-kothari ashish-kothari commented Dec 31, 2025

Update Remote Config API to support managed value types

Added support for Rollouts, Experiments, and Personalization value types in the Remote Config API.

  • Updated ParameterValue to include RolloutValue, PersonalizationValue, and ExperimentValue subclasses.
  • Added factory methods ofRollout, ofPersonalization, and ofExperiment to ParameterValue.
  • Updated TemplateResponse to parse rolloutValue, personalizationValue, and experimentValue fields from the backend response.
  • Added unit tests for the new value types.
  • Fixes Remote config publishTemplate override running rollouts #1092
Update Remote Config API to support managed value types

Added support for Rollouts, Experiments, and Personalization value types in the Remote Config API.
- Updated `ParameterValue` to include `RolloutValue`, `PersonalizationValue`, and `ExperimentValue` subclasses.
- Added factory methods `ofRollout`, `ofPersonalization`, and `ofExperiment` to `ParameterValue`.
- Updated `TemplateResponse` to parse `rolloutValue`, `personalizationValue`, and `experimentValue` fields from the backend response.
- Added unit tests for the new value types.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @ashish-kothari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Firebase Remote Config API by introducing support for advanced managed value types. This change enables the system to handle more complex configuration scenarios, such as A/B testing, phased rollouts, and personalized content delivery, directly through the Remote Config parameters. The modifications involve extending existing data structures and parsing logic to accommodate these new capabilities.

Highlights

  • Support for Managed Value Types: The Remote Config API now supports managed value types, specifically Rollouts, Experiments, and Personalization, allowing for more dynamic configuration management.
  • ParameterValue Enhancements: The ParameterValue class has been updated to include new subclasses (RolloutValue, PersonalizationValue, ExperimentValue) and corresponding factory methods (ofRollout, ofPersonalization, ofExperiment) for creating these new types.
  • Template Response Parsing: The TemplateResponse class has been modified to correctly parse rolloutValue, personalizationValue, and experimentValue fields received from the backend.
  • Comprehensive Unit Tests: New unit tests have been added across various classes to ensure the correct creation, parsing, and equality checks for the newly introduced managed value types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for managed value types (Rollouts, Experiments, and Personalization) in the Remote Config API. The changes are well-structured, adding new subclasses to ParameterValue, corresponding factory methods, and updating TemplateResponse to handle the new types from the backend. The unit tests are also updated to cover these new features. My review includes a critical fix for a potential JSON parsing issue due to a mismatched @Key annotation, suggestions to improve code conciseness using Java Streams, and a naming suggestion to enhance API consistency.

@ashish-kothari ashish-kothari changed the title feat(rc)Support Remote Config managed value types (#1164) Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant