Skip to content

Conversation

@thameezb
Copy link
Contributor

@thameezb thameezb commented Mar 13, 2021

Closes #415

Enables support for Firebase DBs hosted in the EU

@google-cla
Copy link

google-cla bot commented Mar 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@thameezb
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response. This somehow fell through the cracks. I just had one suggestion. And please rebase agains the dev branch. We don't directly push to the default branch.

Copy link
Contributor Author

@thameezb thameezb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto dev

@thameezb thameezb force-pushed the fix/enableSupportForEU branch from ee9d30b to 9c436d4 Compare April 27, 2021 14:17
@thameezb thameezb requested a review from hiranya911 April 27, 2021 14:18
@hiranya911 hiranya911 changed the title fix: enable support for firebasedatabase.app May 14, 2021
@hiranya911 hiranya911 changed the base branch from master to dev May 14, 2021 21:39
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 merged commit 18d371c into firebase:dev May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants