Skip to content

refactor: remove authViewRoutes and remove error API from AuthService and moved to View layer. #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
russellwheatley merged 8 commits into from
Nov 6, 2025
Merged

refactor: remove authViewRoutes and remove error API from AuthService and moved to View layer. #1297

russellwheatley merged 8 commits into from
Nov 6, 2025

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 6, 2025 •
edited
Loading

Changes

  • Removed unused authViewRoutes from AuthService.
  • Refactored error modal from AuthService by moving it to the View layer. The AuthService shouldn't be handling this and it isn't part of the API design.
  • made reportError() optional so user can still use buttons without needing to pass into environment.
demolaf
demolaf reviewed Nov 6, 2025
View reviewed changes
FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Views/AuthPickerView.swift
}

/// Closure for reporting errors from child views
private func reportError(_ error: Error) {
Copy link
Member

@demolaf demolaf Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
@russellwheatley russellwheatley merged commit 7e1dcee into development Nov 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@russellwheatley @demolaf