OpenAPI schema sync (v3.2.0)#211
Open
fingerprint-dx-team-actions-runner[bot] wants to merge 7 commits intomainfrom
Open
OpenAPI schema sync (v3.2.0)#211fingerprint-dx-team-actions-runner[bot] wants to merge 7 commits intomainfrom
fingerprint-dx-team-actions-runner[bot] wants to merge 7 commits intomainfrom
Conversation
fingerprint-dx-team-actions-runner
Bot
requested review from
Orkuncakilkaya,
TheUnderScorer,
erayaydin and
ilfa
as code owners
fingerprint-dx-team-actions-runner
Bot
force-pushed
the
feat/open-api-v3.2.0
branch
from
5759871 to
e242aa9
Compare
fingerprint-dx-team-actions-runner
Bot
force-pushed
the
feat/open-api-v3.2.0
branch
from
e242aa9 to
2fb58fb
Compare
Contributor
|
🟢 Coverage increased by 85.55% Code Coverage ReportCoverage Report
Files Coverage
|
…iles and FILES manifest
Add proper test implementations for `RareDevicePercentileBucket` and `SearchEventsRareDevicePercentileBucket`.
Contributor
🚀 Following releases will be created using changesets from this PR:@fingerprint/php-sdk@7.1.0Minor Changes
|
erayaydin
approved these changes
Apr 29, 2026
Member
erayaydin
left a comment
erayaydin
left a comment
There was a problem hiding this comment.
LGTM. Added an update for the test case, fyi
Orkuncakilkaya
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reversequery parameter default so it does not imply a client-side default..openapi-generator/FILESto match the current output ofbash ./scripts/generate.sh.Discussion point: generated test files and
.openapi-generator/FILESThe new rare-device enum test files are tracked and still exist, but after a second generation run OpenAPI Generator skips existing PHP test files and drops those skipped files from
.openapi-generator/FILES. This matches the current template consistency check output, but reviewers may want to confirm whether we are comfortable with the manifest representing files written in the latest generation run rather than every tracked generated test file.