Skip to content

Remove phantomjs from installation steps #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2020
Merged

Remove phantomjs from installation steps #22

merged 1 commit into from
May 4, 2020

Conversation

etagwerker
Copy link
Member

Hey @arielj,

This PR fixes #21.

Please check it out.

Thanks!
@etagwerker etagwerker requested a review from arielj May 4, 2020 13:50
arielj
arielj approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we shouldn't use phantomjs anywhere
@arielj arielj merged commit fee6fea into master May 4, 2020
@etagwerker etagwerker deleted the fixes/remove-phantomjs branch May 4, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@etagwerker @arielj