Skip to content

Conversation

@tarunkartik
Copy link

Summary

Fixes issue #1015 where PlotJuggler crashes when trying to start a UDP server.

  • Was not able to recreate the exact scenario that reporter experienced but the stack trace in the video shows that the error was an std::out_of_range exception within UDP::start().
  • The only possible location that can happen is when the at() function is called on the parserFactories()

Changes

  • Replaced the call to at() with a safer lookup by calling find() inside the lambda for onComboChanged()
  • Provided a fallback in case the selected_protocol does not exist

Testing

  • Built in docker container
  • Manually tested UDP streaming
@facontidavide
Copy link
Owner

nice ,but I don't thing that we should default to another one. we should just close the connection, IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants