fix(ios): dismiss Modal from presenting VC to handle presented view controllers #55005
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When a Modal has another view controller presented on top of it (e.g., a sheet using
UISheetPresentationController), callingdismissViewControllerAnimated:on the modal itself only dismisses the topmost presented view controller, leaving the modal in an inconsistent state where it remains presented but its React content is unmounted—resulting in a blank screen.This fix dismisses from the presenting view controller instead, which correctly dismisses the entire presentation chain including any view controllers presented on top of the modal.
This issue affects any library that presents view controllers on top of RN Modal, such as @lodev09/react-native-true-sheet.
Changelog:
[iOS] [Fixed] - Modal now correctly dismisses when another view controller is presented on top of it
Test Plan:
<Modal>visibleprop tofalseExpected: Both the sheet and modal dismiss, returning to the original screen
Actual: The sheet dismisses but the modal remains presented with blank/black content
Before
before.mov
After
after.mov