Skip to content

fix: color scheme in appearance state after setting it to unspecified #54993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ismarbesic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: color scheme in appearance state after setting it to unspecified #54993

ismarbesic wants to merge 1 commit into from
+1 −1

Conversation

@ismarbesic
Copy link
Contributor

@ismarbesic ismarbesic commented Dec 29, 2025 •
edited
Loading

Summary:

Fixed the value of the color scheme in the appearance state after setting it to unspecified when state updates. The issue is described here #54959. This is a regression from #53397 and should be reproducible from 0.82 and higher. The useColorScheme() hook will return "unspecified" when you change the appearance from system color (dark or light) to system which breaks many apps using the value to determine whether to use dark/light mode colors.

Changelog:

[GENERAL] [FIXED] - Fix color scheme in appearance state after setting it to unspecified

Test Plan:

  1. Run the reproducer app in the issue - use dark mode when launching the app, press "change to dark" and then "change to system". The hook will return "unspecified" although the correct behavior should be dark.
  2. Apply the changes in this PR.
  3. The correct behavior should be seen.
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 29, 2025
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

2 participants

@ismarbesic @facebook-github-bot