-
Notifications
You must be signed in to change notification settings - Fork 25k
[RN][iOS][HermesV1] Use Hermes V1 as default engine #54989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cipolleschi
wants to merge
7
commits into
main
Choose a base branch
from
cipolleschi/enable-hermes-v1-by-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D89881943. |
Job Summary for GradleTest All :: build_android
|
0da20c6 to
5064dfa
Compare
5064dfa to
350a654
Compare
|
I’m pretty new to React Native and this change for iOS looks great. Could you help me understand if Android will use Hermes V1 by default too? |
Contributor
Author
|
@complexapps2026 the goal is also for Android to do that. this PR only contains changes related to iOS. A similar PR for Android will be opened soon! |
30b8850 to
473d292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change makes Hermes V1 the default engine for React Native for iOS. This change needs to land before the branch cut of react native 0.84
Changelog:
[iOS][Changed] - Make Hermes V1 the default engine for iOS
Test Plan:
bundle exec pod installand verified that Hermes V1 is used when building from source