Skip to content

Conversation

@fguitton
Copy link
Contributor

@fguitton fguitton commented Aug 6, 2021

The latest release of workbox-build is not being pulled by react-scripts due to an explicit dependency on workbox-webpack-plugin@6.1.5.

Since there are no breaking changes mentioned in the Workbox releases notes, this PR updated the version to 6.2.0

@fguitton fguitton changed the title [WIP] Fix sub-dependency issue from workbox-webpack-plugin Aug 6, 2021
@fguitton fguitton marked this pull request as ready for review August 6, 2021 10:31
@ryota-murakami
Copy link
Contributor

Nice! This should be merge soon! cc: @raix

@raix raix linked an issue Aug 6, 2021 that may be closed by this pull request
@raix raix added this to the 5.0 milestone Aug 6, 2021
@raix
Copy link
Contributor

raix commented Aug 6, 2021

Thanks @fguitton for the pr.
@iansu / @mrmckeb do we need to run yarn compile:lockfile on dependency updates?

@fguitton fguitton changed the title Fix dependency issue after workbox-webpack-plugin release Aug 15, 2021
@mrmckeb
Copy link
Contributor

mrmckeb commented Aug 18, 2021

Sorry @raix, missed that comment - no need, that's a part of the release workflow I think.

@iansu iansu merged commit 498c0cf into facebook:main Aug 18, 2021
@iansu
Copy link
Contributor

iansu commented Aug 18, 2021

Thanks!

@fguitton fguitton deleted the fix-deps/workbox-build branch August 18, 2021 18:28
EhsanFortuna pushed a commit to EhsanFortuna/create-react-app that referenced this pull request Aug 23, 2021
…ook#11292)

* fix: Sub-dependency of workbox-webpack-plugin failed to yeild the correct version

* chore: Bump workbox-webpack-plugin to 6.2.4 to address regressions
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
…ook#11292)

* fix: Sub-dependency of workbox-webpack-plugin failed to yeild the correct version

* chore: Bump workbox-webpack-plugin to 6.2.4 to address regressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment