feat(self-host): optional CUSTOM_DOMAIN for non-prod stages - #227
Open
CristianDeluxe wants to merge 1 commit into
Open
feat(self-host): optional CUSTOM_DOMAIN for non-prod stages#227CristianDeluxe wants to merge 1 commit into
CristianDeluxe wants to merge 1 commit into
Conversation
CristianDeluxe
force-pushed
the
selfhost-custom-domain
branch
from
August 18, 2026 16:28
c684e65 to
8114213
Compare
oluwaseunmauwedo
pushed a commit
to oluwaseunmauwedo/open-seo
that referenced
this pull request
Aug 25, 2026
ramonmnavarro-byte
pushed a commit
to ramonmnavarro-byte/open-seo
that referenced
this pull request
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept for #226 — I read
docs/CONTRIBUTING.md, so no merge expected; this is here to make the issue concrete.Reads an optional
CUSTOM_DOMAINenv var (sameoptionalVarmechanism as the rest of the config) and passes it to the Workerdomainprop on non-prod stages. Prod keeps its hardcoded domains. Unset, nothing changes.Running on our selfhost stage since 2026-08-15: with
CUSTOM_DOMAIN=seo.<our-domain>in.env.selfhostthe deploy reportsReconciling custom domains (1)and the domain survives every deploy; before the change the reconcile deleted it (Reconciling custom domains (0)).