Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Oct 20, 2025

Continuation of #20736, and should be the last one. This fully migrates to solely using the environment variables instead of the fixed config.

@serathius, @joshjms

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nwnt
Once this PR has been reviewed and has the lgtm label, please assign siyuanfoundation for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.20%. Comparing base (cca79e6) to head (4bcb2ea).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files

see 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20817      +/-   ##
==========================================
+ Coverage   69.13%   69.20%   +0.07%     
==========================================
  Files         422      422              
  Lines       34824    34824              
==========================================
+ Hits        24075    24100      +25     
+ Misses       9349     9326      -23     
+ Partials     1400     1398       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca79e6...4bcb2ea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ivanvc
Copy link
Member

ivanvc commented Oct 20, 2025

@nwnt, it looks like your branch is out of date and it needs a rebase, as it is showing changes I did to the Makefile.


// CheckHealth checks health of all etcd nodes
func CheckHealth() bool {
cfg := common.MakeConfig(NodeCount)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split the PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm this PR is trying to remove the dependency on the CFG_NODE_COUNT build-time flag and its references such as those in the code, the make file, and docker compose files. Most of the changes are related to that removal. Do you want me to try breaking the PR further? I'm thinking maybe I'll just start with the code part, then docker compose and then the make file. Does that sound ok to you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please focus on making it reviewable.

Signed-off-by: Nont <nont@duck.com>
@nwnt nwnt force-pushed the clean-up-antithesis-static-path branch from 9fd7508 to 4bcb2ea Compare October 21, 2025 03:10
@nwnt
Copy link
Member Author

nwnt commented Oct 21, 2025

@nwnt, it looks like your branch is out of date and it needs a rebase, as it is showing changes I did to the Makefile.

Hey @ivanvc, I have just done the rebase. I still see all the changes I made though. Can you put the link to your changes so that I can have a look and compare?

@k8s-ci-robot
Copy link

k8s-ci-robot commented Oct 21, 2025

@nwnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-386 4bcb2ea link true /test pull-etcd-e2e-386
pull-etcd-robustness-arm64 4bcb2ea link true /test pull-etcd-robustness-arm64
pull-etcd-coverage-report 4bcb2ea link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment