Skip to content

Conversation

@i3water
Copy link
Contributor

@i3water i3water commented Mar 30, 2018

Thanks,

I want to add an arduino uno like board WiFiduino

@i3water i3water changed the title Wan to add board WiFiduino Mar 30, 2018
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically approved
(the site http://wifiduino.com/esp8266 is 404)

@i3water
Copy link
Contributor Author

i3water commented Mar 30, 2018

how about this site https://wifiduino.com/esp8266

@d-a-v
Copy link
Collaborator

d-a-v commented Mar 30, 2018

Yes, then you need to:

  • update the website link
  • generate and commit documentation (--docgen)
  • push updates to your repo
@d-a-v
Copy link
Collaborator

d-a-v commented Mar 30, 2018

It seems you modified some files by hand. The only editable ones are boards.txt.py and variant/*. The others are generated by the script, then Travis-CI double checks by regenerating and diffing them.
You need to regenerate all the other files with boards.txt.py's --*gen options and commit/push them as-is.

@i3water
Copy link
Contributor Author

i3water commented Mar 31, 2018

Yes, I modified boards.text, doc/boards.rst, package/package_esp8266com_index.template.json by hand. I tried tools/boards.text.py --docgen --boardsgen --packagegen , there nothing replaced but just open boards.txt.py, let me check is there something wrong with my setting.


Yes, it`s my fault, I found the wrong setting.

Thanks!

@i3water
Copy link
Contributor Author

i3water commented Mar 31, 2018

I had regenerate the boards doc and package with --*gen, but unfortunatly them all check failed.Is there something wrong with my regenerate or commit?


CI: Check if files generated by boards.txt.py are up to date #4379

If any difference is found between generated files and files in the repository, CI build will fail

So,this check fail is normal?

@i3water
Copy link
Contributor Author

i3water commented Mar 31, 2018

:(
Sadly, I don't know what to do with CI check fail.
hope to receive your reply.

Thanks.


Surprised.I use --*gen to regenerate all files and modified them by hand.
Now, the files all pass the CI check.

Thanks!

@d-a-v d-a-v merged commit 7ae8f98 into esp8266:master Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants