Skip to content

WiFiClient: clean up ClientContext before connecting #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devyte merged 4 commits into from
Mar 23, 2018
Merged

WiFiClient: clean up ClientContext before connecting #4516

devyte merged 4 commits into from
Mar 23, 2018

Conversation

@igrr
Copy link
Member

@igrr igrr commented Mar 14, 2018

Fixes #4497
@igrr
Copy link
Member Author

igrr commented Mar 14, 2018

WIP because i want to add a test case for this.
@igrr igrr mentioned this pull request Mar 14, 2018
Closed
@Eszartek
Copy link

Eszartek commented Mar 14, 2018

I think the references to "client" should be "_client"
@igrr igrr force-pushed the bugfix/wificlient_connect_leak branch from 3e737f4 to 9a4b072 Compare March 14, 2018 13:42
@devyte devyte mentioned this pull request Mar 16, 2018
Closed
@devyte
Copy link
Collaborator

devyte commented Mar 22, 2018

@igrr will you be adding to this pr?
d-a-v added a commit to d-a-v/Arduino that referenced this pull request Mar 22, 2018
@d-a-v
device test for esp8266#4516 (WiFiClient leaking)
31b8ba1
@d-a-v d-a-v mentioned this pull request Mar 22, 2018
Merged
@d-a-v
Copy link
Collaborator

d-a-v commented Mar 22, 2018

I think we can merge here
@d-a-v
Copy link
Collaborator

d-a-v commented Mar 23, 2018 •
edited
Loading

@igrr is does #4549's way of testing look like what you intended to do ?
@igrr
Copy link
Member Author

igrr commented Mar 23, 2018

@d-a-v, pretty much, yes :) I got stuck yak shaving trying to remove the need for globals in the script and I think I ended up writing a new test framework. Let's merge your test :)
devyte pushed a commit that referenced this pull request Mar 23, 2018
@d-a-v @devyte
device test for #4516 (WiFiClient leaking) (#4549)
d5cbd91 
* device test for #4516 (WiFiClient leaking)

* simply count the number of connections that do not change heap

* remove unused heapLost

* + python server (to not depend on gateway's opened tcp port)

* remove old&bad define

* fix another old address
@devyte
Copy link
Collaborator

devyte commented Mar 23, 2018

@igrr is this pr ready for merging, or is additional work needed?
@igrr igrr changed the title [WIP] WiFiClient: clean up ClientContext before connecting Mar 23, 2018
@igrr
Copy link
Member Author

igrr commented Mar 23, 2018

Should be good to merge along with @d-a-v 's tests in #4549!
@devyte devyte merged commit 95b1348 into master Mar 23, 2018
@debsahu debsahu mentioned this pull request Mar 24, 2018
Closed
bryceschober pushed a commit to bryceschober/Arduino that referenced this pull request Apr 5, 2018
@d-a-v
device test for esp8266#4516 (WiFiClient leaking) (esp8266#4549)
0a9c39c 
* device test for esp8266#4516 (WiFiClient leaking)

* simply count the number of connections that do not change heap

* remove unused heapLost

* + python server (to not depend on gateway's opened tcp port)

* remove old&bad define

* fix another old address

(cherry picked from commit d5cbd91)
bryceschober pushed a commit to bryceschober/Arduino that referenced this pull request Apr 5, 2018
@igrr
WiFiClient: clean up ClientContext before connecting (esp8266#4516)
572dff1 
Fixes esp8266#4497

(cherry picked from commit 95b1348)
@devyte devyte deleted the bugfix/wificlient_connect_leak branch December 11, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@igrr @Eszartek @devyte @d-a-v