fix(grid3d): Fixed coloring if no property data proived #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LeonidPolukhin
commented
Sep 5, 2024
LeonidPolukhin
commented
- Fixed case when no property data is given to Grid3DLayer coloring by undefined property is performed.
- Fixed precision issue with undefined property value in case of continuous property.
added 8 commits
July 1, 2024 11:39
LeonidPolukhin
added
bug
Collaborator
|
LGTM, but why wasn't this bug caught by the tests? Would it make sense to create a new story for this specific case? |
w1nklr
approved these changes
Sep 5, 2024
Contributor
Author
The existing examples are not that impressive being displayed in a constant color. Perhaps it would be nice to make a grid with complicated geometry. |
hkfb
pushed a commit
that referenced
this pull request
Sep 5, 2024
## [0.30.1](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.30.0...subsurface-viewer@0.30.1) (2024-09-05) ### Bug Fixes * **grid3d:** Fixed coloring if no property data proived ([#2224](#2224)) ([3216861](3216861))
Collaborator
|
🎉 This issue has been resolved in version subsurface-viewer@0.30.1 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.