Fix alpha blending in WebGL backends - #650
Merged
Merged
Conversation
This reverts commit 91bdf9b
emilk
requested changes
Aug 25, 2021
emilk
left a comment
emilk
left a comment
Owner
There was a problem hiding this comment.
This is wonderful work; thank you so much!
As I noted in my review I think the WebGL1 pipeline should remain as it was, but the improvements to the WebGL2 renderer is massive, and works great! ❤️
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Owner
|
Thank you again! |
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
Add a render-to-texture step with an sRGBA8 texture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes alpha blending in the WebGL backends by first blending everything in a linear framebuffer, before converting the result to sRGB in a second shader.
The results of the color test are now identical to the egui_glium backend when using the WebGL2 backend.
The WebGL1 backend suffers from reduced precision in dark colors without the
SRGB8_ALPHA8format and still doesn't have correct texture interpolation.Color test with the change (I have since removed the warning):
WebGL2
WebGL1
(Sorry for not following the contributing guidelines exactly ("First file an issue" and all that). This was a spontaneous test as I didn't know whether it was even possible and I didn't wan't to file an issue the same minute as closing it (Should I?).)