Skip to content

Use minimum of 5 seconds for interval between central config calls #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2022
Merged

Use minimum of 5 seconds for interval between central config calls #1652

merged 3 commits into from
Oct 3, 2022

Conversation

beniwohli
Copy link
Contributor

What does this pull request do?

Handling of negative values is not implemented, as this is not allowed per RFC: https://www.rfc-editor.org/rfc/rfc7234#section-5.2.2.8

Related issues

closes #1645
@beniwohli
Use minimum of 5 seconds for interval between central config calls
70aac56 
Handling of negative values is not implemented, as this is not allowed
per RFC: https://www.rfc-editor.org/rfc/rfc7234#section-5.2.2.8

closes elastic#1645
@apmmachine
Copy link
Contributor

apmmachine commented Sep 28, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-03T17:30:37.767+0000

  • Duration: 29 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 5029
Skipped 3378
Total 8407

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)
@apmmachine
Copy link
Contributor

apmmachine commented Sep 28, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (67/67) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 91.296% (18063/19785) 👍 1.447
Conditionals 74.607% (2800/3753) 👎 -2.543
@beniwohli
Copy link
Contributor Author

Regarding negative values, turns out we "accidentally" already behave as intended by the updated spec, on account of the regex failing to match negative values and falling back to the default value. I added a test to make sure we don't accidentally fix that accident.
@beniwohli beniwohli requested a review from basepi October 3, 2022 07:08
basepi
basepi approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@basepi basepi enabled auto-merge (squash) October 3, 2022 17:41
@basepi basepi merged commit 5b80432 into elastic:main Oct 3, 2022
v1v added a commit to v1v/apm-agent-python that referenced this pull request Oct 11, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/unit-test-w…
a5d640e 
…ith-k8s-skaffold

* upstream/main:
  bump python versions and use docker slim versions (elastic#1661)
  use github actions for pre-commit checks (elastic#1658)
  Use typing.TypeVar on decorators' type hints (elastic#1655)
  Use minimum of 5 seconds for interval between central config calls (elastic#1652)
  fix errors in pymongo tests introduced in elastic#1639 (elastic#1648)
  only use content-type and content-encoding headers for POSTing events (elastic#1651)
  fix starlette 0.21 tests (elastic#1653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python
3 participants
@beniwohli @apmmachine @basepi