Skip to content

Add AWS Request ID to botocore span context #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Aug 31, 2022

What does this pull request do?

Adds span.context.http.request.id with the AWS request ID to all botocore requests.

This field is not in the intake yet, but will be in 8.5.0

Related issues

Closes #1524

@basepi basepi requested a review from trentm August 31, 2022 20:59
@basepi basepi force-pushed the boto_requestid_1524 branch from fda5465 to 70fbdad Compare August 31, 2022 20:59
@apmmachine
Copy link
Contributor

apmmachine commented Aug 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-31T21:01:37.511+0000

  • Duration: 28 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 4974
Skipped 3338
Total 8312

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (66/66) 💚
Files 100.0% (225/225) 💚
Classes 100.0% (225/225) 💚
Lines 89.812% (17454/19434)
Conditionals 77.128% (3190/4136)
@basepi basepi merged commit 45abe97 into elastic:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
close