Skip to content

Kafka support #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 24, 2022
Merged

Kafka support #1555

merged 7 commits into from
May 24, 2022

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented May 23, 2022

What does this pull request do?

This pull request is based on #964. Changes include:

  • automatically create transactions when looping over results
  • instrument KadkaConsumer.poll
  • add binary TraceParent handling
  • added support for span links
  • add tests

Closes #853

Rohit-dot-KumarAM and others added 4 commits October 30, 2020 20:52
Changes include:
 * automatically create transactions when looping over results
 * instrument KadkaConsumer.poll
 * add binary TraceParent handling
 * added support for span links
 * add tests
@apmmachine
Copy link
Contributor

apmmachine commented May 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-24T12:56:23.245+0000

  • Duration: 32 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 4863
Skipped 3455
Total 8318

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented May 23, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.45% (17008/19014) 👍 0.124
Conditionals 76.431% (3097/4052) 👍 0.126
Copy link
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough. Great job!

I think all this needs is a CHANGELOG entry.

@beniwohli beniwohli enabled auto-merge (squash) May 24, 2022 13:03
@beniwohli beniwohli merged commit 9be1bae into elastic:main May 24, 2022
@beniwohli beniwohli deleted the kafka-support branch May 24, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
close