Skip to content

Reduce stack_trace_limit default from 500 to 50 #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Reduce stack_trace_limit default from 500 to 50 #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62fd73b
Reduce stack_trace_limit default from 500 to 50
basepi Mar 21, 2022
4fb8eab
CHANGELOG and docs
basepi Mar 21, 2022
9b8a053
Fix PR number
basepi Mar 21, 2022
f22926b
Merge branch 'main' into stack_trace_limit
basepi Mar 22, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ endif::[]

* Fix Sanic integration to properly respect the `capture_body` config {pull}1485[#1485]
* Lambda fixes to align with the cross-agent spec {pull}1489[#1489]
* Change default for `stack_trace_limit` from 500 to 50 {pull}1492[#1492]


[[release-notes-6.x]]
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ Setting an upper limit will prevent edge cases from overloading the agent and th
[options="header"]
|============
| Environment | Django/Flask | Default
| `ELASTIC_APM_STACK_TRACE_LIMIT` | `STACK_TRACE_LIMIT` | `500`
| `ELASTIC_APM_STACK_TRACE_LIMIT` | `STACK_TRACE_LIMIT` | `50`
|============

This limits the number of frames captured for each stack trace.
Expand Down
2 changes: 1 addition & 1 deletion elasticapm/conf/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ class Config(_ConfigBase):
"TRANSACTION_SAMPLE_RATE", type=float, validators=[PrecisionValidator(4, 0.0001)], default=1.0
)
transaction_max_spans = _ConfigValue("TRANSACTION_MAX_SPANS", type=int, default=500)
stack_trace_limit = _ConfigValue("STACK_TRACE_LIMIT", type=int, default=500)
stack_trace_limit = _ConfigValue("STACK_TRACE_LIMIT", type=int, default=50)
span_frames_min_duration = _ConfigValue(
"SPAN_FRAMES_MIN_DURATION",
default=5,
Expand Down