Skip to content

Conversation

@rschnekenbu
Copy link
Contributor

What it does

Adds an application prop to define the location of the configuration area.
This property can be used by theia-based applications to customize their own configuration area. The logic of the THEIA_CONFIG_DIR environment variable should still works and it should override this application prop, without the need of overriding the environment variable server.

fixes #14318

Contributed on behalf of STMicroelectronics

How to test

  • Sample application can be used without modification. '.theia' should be the default configuration folder (default prop is used)
  • Setting an env variable to another folder (export THEIA_CONFIG_DIR=".theia-configDir") for example, and re-test with the sample application.
  • Unset the environment variable and setting the application property in the sample application package.json to "configurationFolder" : ".theia-example". Config dir shall be $home/.theia-example
  • Set again the env property. The environment property should override the configurationFolder value

Follow-ups

Review checklist

Reminder for reviewers

…ation

fixes eclipse-theia#14318

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu merged commit fa7597a into eclipse-theia:master Oct 28, 2024
@jfaltermeier jfaltermeier added this to the 1.55.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants