Init commit for DynRNN understand sentiment#30
Merged
dzhwinter merged 5 commits intodzhwinter:masterfrom Jan 8, 2018
Merged
Conversation
dzhwinter
reviewed
Jan 4, 2018
| rnn.output(hidden) | ||
|
|
||
| last = fluid.layers.sequence_pool(rnn(), 'last') | ||
| logit = fluid.layers.fc(input=last, size=2, act='softmax') |
Owner
There was a problem hiding this comment.
We obey the convention that split model out of data pipeline,
just like https://github.com/dzhwinter/benchmark/blob/master/fluid/resnet.py#L75 .
| cPickle.dump(word_dict, f, cPickle.HIGHEST_PROTOCOL) | ||
|
|
||
|
|
||
| def cache_reader(reader, clean): |
Owner
There was a problem hiding this comment.
We do not have a unified way to accelerate our benchmark demos. I doubt about the reasonability of caching the dataset with CPickle when do benchmark.
| @@ -0,0 +1,193 @@ | |||
| import argparse | |||
Owner
There was a problem hiding this comment.
We have a old one understand_sentiment_dynamic_rnn.py, I think we can delete that one and replace with this one?
dzhwinter
approved these changes
Jan 8, 2018
Owner
dzhwinter
left a comment
dzhwinter
left a comment
There was a problem hiding this comment.
We can merge this PR and refine the io part style same with other scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic RNN 情感分类