Skip to content
This repository was archived by the owner on Jul 6, 2018. It is now read-only.

Conversation

@agamble
Copy link

@agamble agamble commented May 2, 2013

Using the bootstrap URL on github is not optimal, as for this type of content, it is much better to use a proper CDN that is optimised for low latency and speed globally. Another benefit of using the CloudFlare CDN is that the protocol is not included. This means that the bootstrap request will match the global one, eg: http with http or https with https.

@dyve
Copy link
Owner

dyve commented May 3, 2013

Did you delete the pull request?

On 2 mei 2013 at 2 mei 2013, alexandergamble (notifications@github.com) wrote:
Using the bootstrap URL on github is not optimal, as for this type of content, it is much better to use a proper CDN that is optimised for low latency and speed globally. Another benefit of using the CloudFlare CDN is that the protocol is not included. This means that the bootstrap request will match the global one, eg: http with http or https with https.

You can merge this Pull Request by running
git pull https://github.com/alexandergamble/django-bootstrap-toolkit master
Or view, comment on, or merge it at:
  #75
Commit Summary
• Changed bootstrap server URL to CloudFlare CDN for performance reasons
File Changes
• M bootstrap_toolkit/templatetags/bootstrap_toolkit.py (2)
Patch Links:
https://github.com/dyve/django-bootstrap-toolkit/pull/75.patch
https://github.com/dyve/django-bootstrap-toolkit/pull/75.diff

@agamble
Copy link
Author

agamble commented May 3, 2013

It isn't possible to delete pull requests.

@agamble
Copy link
Author

agamble commented May 21, 2013

Any thoughts about implementing this?

dyve pushed a commit that referenced this pull request Jun 11, 2013
Changed the default bootstrap URL to a CDN
@dyve dyve merged commit ff3153c into dyve:master Jun 11, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants