[Sqlite-kit]: Avoid duplicate CREATE INDEX during push table recreation #4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-vikng-dev
force-pushed
the
fix/sqlite-push-duplicate-indexes
branch
from
7e5df3c to
f58e918
Compare
…on\n\nFixes duplicate index creation for SQLite/D1 push by removing index creation from the recreate-table helper; indexes are created once from planned create_index statements. Adds regression test to ensure a single CREATE UNIQUE INDEX is emitted.\n\nRefs: drizzle-team#3574
yan-vikng-dev
force-pushed
the
fix/sqlite-push-duplicate-indexes
branch
from
f58e918 to
196709b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3574
Avoid duplicate CREATE INDEX during SQLite/D1 push table recreation by removing index creation in _moveDataStatements. Indexes are created once from planned create_index statements. Adds a regression test.