Skip to content

Set isReferenceAssembly to false if we found the implementation assembly #82242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoeRobich merged 1 commit into from
Feb 1, 2026
Merged

Set isReferenceAssembly to false if we found the implementation assembly #82242

JoeRobich merged 1 commit into from
Feb 1, 2026
+17 −12

Conversation

@KirillOsenkov
Copy link
Member

@KirillOsenkov KirillOsenkov commented Feb 1, 2026

Fixes #82241
@KirillOsenkov KirillOsenkov requested a review from a team as a code owner February 1, 2026 01:31
@KirillOsenkov
Copy link
Member Author

KirillOsenkov commented Feb 1, 2026

I built my own fork of Roslyn with this fix and confirmed that it does decompile the implementation assembly now.
JoeRobich
JoeRobich approved these changes Feb 1, 2026
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KirillOsenkov!
@JoeRobich JoeRobich enabled auto-merge (squash) February 1, 2026 02:04
@JoeRobich
Copy link
Member

JoeRobich commented Feb 1, 2026

This might address #68883 as well
@JoeRobich JoeRobich merged commit 265653e into dotnet:main Feb 1, 2026
25 of 26 checks passed
@KirillOsenkov KirillOsenkov deleted the dev/kirillo/fix-82241 branch February 1, 2026 03:23
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Feb 1, 2026
This was referenced Feb 1, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE VSCode

3 participants

@KirillOsenkov @JoeRobich @davidwengier