Skip to content

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Dec 15, 2025

follow-up moby/buildkit#6397
fixes #56

Enabling signing for cache blobs in GHA cache backend protects against tampering of remote cache. The approach used here keeps the implementation isolated, transparent, and cost-effective. Local testing shows that the additional overhead introduced by copying the cosign binary into the builder container is negligible.

@crazy-max crazy-max force-pushed the gha-cache-sign branch 8 times, most recently from 9591c5c to 84847ab Compare December 15, 2025 12:13
@crazy-max crazy-max changed the title bake: sign github actions cache blobs Dec 15, 2025
@crazy-max crazy-max requested a review from tonistiigi December 15, 2025 12:21
env:
BUILDX_VERSION: "v0.30.1"
BUILDKIT_IMAGE: "moby/buildkit:v0.26.2"
BUILDKIT_IMAGE: "crazymax/buildkit:6397"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in draft until moby/buildkit#6397 is released

@crazy-max crazy-max mentioned this pull request Dec 16, 2025
timestampTreshold = 1
tlogThreshold = ${{ matrix.tlogUpload && '1' || '0' }}
subjectAlternativeName = "https://github.com/docker/github-builder-experimental/.github/workflows/bake.yml*"
issuer = "https://token.actions.githubusercontent.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to verify source repo, build repo (same as san) and I think also ref (master branch/tag should not verify PR cache)

Copy link
Member Author

@crazy-max crazy-max Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, see aeba44b

@crazy-max crazy-max force-pushed the gha-cache-sign branch 3 times, most recently from 181dee3 to 584ef96 Compare December 18, 2025 15:15
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants