Skip to content

Support piping #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2025
Merged

Support piping #901

merged 2 commits into from
Nov 21, 2025

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Nov 21, 2025 •
edited
Loading

Support piping of cagent's output:

cagent exec ./examples/pirate.yaml "hello" | mate
cagent exec --yolo ./examples/shell.yaml "Is there a README.md?" | mate
echo "Is there a README.md?" | cagent exec --yolo ./examples/shell.yaml - | mate
@dgageot
Allow piping cagent output
6120637 
Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot
Reject tool calls of not in a terminal
4025c80 
Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot requested a review from a team as a code owner November 21, 2025 17:09
krissetto
krissetto approved these changes Nov 21, 2025
View reviewed changes
pkg/cli/text.go
p.PrintToolCall(toolCall)
p.Printf("\n%s", bold("Can I run this tool? ([y]es/[a]ll/[n]o): "))

if !isatty.IsTerminal(os.Stdout.Fd()) {
Copy link
Contributor

@krissetto krissetto Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to consider the possible presence of the --yolo flag?
Copy link
Member Author

@dgageot dgageot Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, in yolo mode, we don't enter this function.
@dgageot dgageot merged commit bcdf6ea into docker:main Nov 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dgageot @krissetto