Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Hyper-V: Use Default Switch vSwitch by default #4732

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laozc
Copy link

@laozc laozc commented Jul 17, 2019

Description

Default Switch with NAT was skipped as docker-machine only looks for external vSwitches.

Related issue(s)

  • Currently it requires the user to create an external vSwitch to launch the VM. In some case the provision might fail when the external DHCP does not work.
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "use-default-switch-upstream" git@github.com:laozc/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@tstromberg
Copy link

@afbjorklund - any chance this could be merged?

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
@laozc laozc force-pushed the use-default-switch-upstream branch from e7c21db to bd4616a Compare September 10, 2019 08:07
@afbjorklund
Copy link
Contributor

@tstromberg : merged downstream, not sure if this project is doing any more updates (due to #4537)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants