This repository was archived by the owner on Jul 18, 2025. It is now read-only.
fix openFirewallPorts to build the network name with the same format … #4724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:perryao/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
…used in createInstance, allowing the user to pass a fully-qualified url for network and subnetwork resources Signed-off-by: Mike Perry <mike@mikeperry.io>
|
This PR will be merged? |
|
Can we get this? Is anyone yet support docker machine project? I do not think so :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…used in createInstance, allowing the user to pass a fully-qualified url for network and subnetwork resources
Description
#4335 added support for fully qualified network and subnetwork names in the google driver. This pr builds on that to fix the formatting of the network name in the openFirewallPorts method.
Currently, the driver will append the fully qualified network name to the globalUrl instead of taking it as-is.
Related issue(s)