This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Bugfixes to the SCP command in Windows + Add trusted CA command #4689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "add_trusted_ca_command" git@github.com:deblasis/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842358449896
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
This is to avoid redundancy at the expense of readability Optional commit depending on the team's view on the matter Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
the full path could have spaces on windows, better safe than sorry Signed-off-by: Alessandro De Blasis <alex@deblasis.net>
deblasis
force-pushed
the
add_trusted_ca_command
branch
from
689055a to
e1e5899
Compare
deblasis
force-pushed
the
add_trusted_ca_command
branch
from
e1e5899 to
689055a
Compare
deblasis
force-pushed
the
add_trusted_ca_command
branch
from
689055a to
e1e5899
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi there,
I understand the status of the project, however, this PR addresses issues with the SCP command in Windows (#4444, #4498)
Also, it adds a new feature that allows to upload and trust CA Certificates as described in #1799
Test coverage is almost 100% on that.
Best regards
Related issue(s)